Skip to content
This repository has been archived by the owner on Oct 20, 2021. It is now read-only.

build(esmodule): package src to es module #63

Merged
merged 20 commits into from
Sep 6, 2019
Merged

build(esmodule): package src to es module #63

merged 20 commits into from
Sep 6, 2019

Conversation

Robbie-Han
Copy link
Collaborator

@Robbie-Han Robbie-Han commented Sep 4, 2019 •
edited by Kimi-Gao

Description:
打包生成es module

Reference issue: #57

@Robbie-Han Robbie-Han self-assigned this Sep 4, 2019
@Robbie-Han Robbie-Han added the PR: build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) label Sep 4, 2019
@Robbie-Han Robbie-Han added this to Reviewing in earth-ui@0.6.x via automation Sep 4, 2019
@Robbie-Han Robbie-Han added this to the earth-ui@0.6.x milestone Sep 4, 2019
Kimi-Gao
Kimi-Gao reviewed Sep 4, 2019
View reviewed changes
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
build/build.js Outdated Show resolved Hide resolved
build/build.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Kimi-Gao
Kimi-Gao reviewed Sep 4, 2019
View reviewed changes
build/build.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited

Codecov Report

Merging #63 into master will increase coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   10.56%   10.84%   +0.27%     
==========================================
  Files          70       70              
  Lines        1410     1411       +1     
  Branches      323      322       -1     
==========================================
+ Hits          149      153       +4     
+ Misses        966      964       -2     
+ Partials      295      294       -1
Impacted Files Coverage Δ
src/components/Form/FormSelect/index.js 0% <ø> (ø) ⬆️
src/components/_utils/xhr/index.js 0% <0%> (ø) ⬆️
src/components/Header/index.js 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a3280...f5eea63. Read the comment docs.

Kimi-Gao
Kimi-Gao reviewed Sep 5, 2019
View reviewed changes
config/babelPreset.js Outdated Show resolved Hide resolved
@Kimi-Gao
Copy link
Member

Kimi-Gao commented Sep 5, 2019 •
edited

还剩两个问题：

  1. isndex.js里面的组件名不能重复且使用统一的 import { } from 'earth-ui'方式，目前比较杂
  2. babel编译的时候如何跳过test文件

@Kimi-Gao Kimi-Gao mentioned this pull request Sep 5, 2019
Closed
Kimi-Gao
Kimi-Gao approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@Kimi-Gao Kimi-Gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

earth-ui@0.6.x automation moved this from Reviewing to Reviewer approved Sep 5, 2019
@Kimi-Gao
Copy link
Member

Kimi-Gao commented Sep 6, 2019

@USTC-Han LGTM

@Robbie-Han Robbie-Han merged commit 599c444 into master Sep 6, 2019
earth-ui@0.6.x automation moved this from Reviewer approved to Done Sep 6, 2019
@Robbie-Han Robbie-Han deleted the tree-sharking branch September 6, 2019 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kimi-Gao Kimi-Gao Kimi-Gao approved these changes

Assignees

@Robbie-Han Robbie-Han

Labels
PR: build Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
Projects
No open projects
earth-ui@0.6.x
  
Done (PR)
Milestone
earth-ui@0.6.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Robbie-Han @Kimi-Gao