Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit tests #1337

Closed
1 of 2 tasks
faboweb opened this issue Sep 20, 2018 · 5 comments
Closed
1 of 2 tasks

Refactor unit tests #1337

faboweb opened this issue Sep 20, 2018 · 5 comments
Assignees
@faboweb @jbibla
Labels
epic low priority has been discussed, will be addressed later refactor stale

Comments

@faboweb
Copy link
Collaborator

faboweb commented Sep 20, 2018 •
edited

We want to redesign how the unit tests are written so they are uniform.

Scope:

  • written design proposal
  • implementation of the proposal throughout all tests
@faboweb faboweb added low priority has been discussed, will be addressed later refactor epic labels Sep 20, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Feb 19, 2019 •
edited by fedekunze

Components

@fedekunze

  • AnchorCopy (not used, removed)
  • Page404
  • ShortBech32
  • TmBalance
  • TmBtnCopy (removed)
  • TmBtnReceive (removed)
  • TmLiCopy
  • PagePreferences
  • ModalDeposit
  • ModalPropose
  • ModalVote
  • DelegationModal
  • UndelegationModal

@jbibla

  • TmModalHelp
  • TmModalReceive (removed)
  • TmModalSearch
  • TmOnboarding
  • TmSessionAccountDelete
  • ToolBar
  • LiProposal

@sabau

  • PageGovernance
  • PageProposal
  • TableProposals
  • TabParameters (governance)
  • TabProposals
  • LiValidator

@faboweb

  • PageStaking
  • PageValidator
  • PanelSort
  • TableValidators
  • TabMyDelegations
  • TabParameters (staking)
  • TabValidators
  • UndelegationModal
  • LiCoin
  • PageTransactions

Modules

@fedekunze
Copy link
Contributor

also please update the unit test code style doc while doing this

@faboweb
Copy link
Collaborator Author

faboweb commented Feb 22, 2019

Leet ticket :)

This was referenced Feb 26, 2019
Merged
Merged
Merged
Closed
@faboweb faboweb mentioned this issue Mar 15, 2019
Merged
@fedekunze fedekunze mentioned this issue Mar 21, 2019
Merged
5 tasks
@faboweb faboweb mentioned this issue Mar 22, 2019
Merged
@jbibla
Copy link
Collaborator

jbibla commented Jun 7, 2019

lol @sabau we're still waiting for you

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

@jbibla jbibla

Labels
epic low priority has been discussed, will be addressed later refactor stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sabau @faboweb @jbibla @fedekunze