Add eslint basic rules #2236
Merged
Add eslint basic rules #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2236 +/- ##
===========================================
+ Coverage 95.42% 95.43% +<.01%
===========================================
Files 109 109
Lines 2295 2300 +5
Branches 116 116
===========================================
+ Hits 2190 2195 +5
Misses 92 92
Partials 13 13
|
jbibla
reviewed
Mar 11, 2019
| "brace-style": ["error", "1tbs"], | ||
| "semi": ["error", "never"], | ||
| "no-tabs": ["error"], | ||
| "max-len": ["error", { "code": 80, "ignoreStrings": true, "ignoreComments": true, "ignoreTemplateLiterals": true }], |
There was a problem hiding this comment.
Yeah, basically prettier is enforcing a set of preconfigured rules, I'm picking the easy ones piece by piece, but some take time where those are quick to add
Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
faboweb
previously approved these changes
Mar 12, 2019
jbibla
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Thank you! 馃殌
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: