poquito requests #2289
Merged
poquito requests #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2289 +/- ##
===========================================
+ Coverage 96.91% 97.11% +0.19%
===========================================
Files 105 105
Lines 2304 2322 +18
Branches 117 123 +6
===========================================
+ Hits 2233 2255 +22
+ Misses 61 57 -4
Partials 10 10
|
|
wish it was a poquito PR 😆 |
jbibla
previously requested changes
Mar 18, 2019
jbibla
previously approved these changes
Mar 18, 2019
faboweb
reviewed
Mar 18, 2019
| this.session.signedIn && | ||
| waitTwentyBlocks && | ||
| this.$route.name === `validator` && | ||
| Number(this.myBond) > 0 |
There was a problem hiding this comment.
what happens if you load this page first and the bond has not been loaded yet?
There was a problem hiding this comment.
I haven't run into that issue
There was a problem hiding this comment.
- create account
- delegate
- go on validator page
- refresh
faboweb
reviewed
Mar 18, 2019
faboweb
reviewed
Mar 18, 2019
faboweb
reviewed
Mar 18, 2019
faboweb
reviewed
Mar 18, 2019
…s/voyager into fedekunze/poquito-requests
…s/voyager into fedekunze/poquito-requests
sabau
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1914
Part of #2175
Description:
Thank you! 🚀
For contributor:
PENDING.mdwith issue # and GitHub usernameFiles changedin the github PR explorerFor reviewer: