Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build master against mainnet nodes #2291

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Build master against mainnet nodes #2291

merged 2 commits into from
Mar 15, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Mar 15, 2019

Description:

  • Circle will build against mainnet by default on master

Thank you! 馃殌


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Mar 15, 2019

Codecov Report

Merging #2291 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2291      +/-   ##
===========================================
- Coverage    96.74%   96.74%   -0.01%     
===========================================
  Files          106      106              
  Lines         2306     2304       -2     
  Branches       116      116              
===========================================
- Hits          2231     2229       -2     
  Misses          63       63              
  Partials        12       12
Impacted Files Coverage 螖
app/src/renderer/vuex/modules/session.js 100% <0%> (酶) 猬嗭笍

@sabau
Copy link
Contributor Author

sabau commented Mar 15, 2019

I've launched a build against this branch with the same filter
test it

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@faboweb faboweb merged commit 0512799 into develop Mar 15, 2019
@faboweb faboweb deleted the sabau/master-to-mainnet branch March 15, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants