Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework subscription logic #2

Open
octfx opened this issue Dec 6, 2019 · 1 comment
Open

Rework subscription logic #2

octfx opened this issue Dec 6, 2019 · 1 comment
Labels
enhancement New feature or request performance
Milestone
1.1.0

Comments

@octfx
Copy link
Member

octfx commented Dec 6, 2019

Items will automatically subscribe to the click$, trace$, dragging$ observables upon entering the active/activeSelected state. Every other state will trigger an unsubscribe action.

This behaviour causes a lot of overhead on every state change.
@octfx octfx added enhancement New feature or request performance labels Dec 6, 2019
@octfx octfx added this to the 1.1.0 milestone Dec 10, 2019
@octfx
Copy link
Member Author

octfx commented Dec 10, 2019

Branch d03eaee removes the unsubscribe logic.

  • 🐛 When in marking-mode navigating back to the parent results in a forward navigation after releasing the mouse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@octfx