Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go_package option in proto files to v2 #336

Open
hallazzang opened this issue Jul 13, 2022 · 0 comments
Open

Update go_package option in proto files to v2 #336

hallazzang opened this issue Jul 13, 2022 · 0 comments
Assignees
@hallazzang
Labels
help wanted Extra attention is needed

Comments

@hallazzang
Copy link
Contributor

squad/proto/squad/liquidity/v1beta1/liquidity.proto

Line 9 in a755b70

option go_package = "github.com/cosmosquad-labs/squad/x/liquidity/types";

Should we update this line as below?

option go_package                      = "github.com/cosmosquad-labs/squad/v2/x/liquidity/types";

After making changes in local machine, it seems there's no major effect by changing package path in proto file.
We need more discussion about this.
@hallazzang hallazzang added the help wanted Extra attention is needed label Jul 13, 2022
@hallazzang hallazzang self-assigned this Jul 13, 2022
@hallazzang hallazzang mentioned this issue Jul 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hallazzang