Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up intro activity and layout #191

Closed

Conversation

qqdasdzxc
Copy link

Hello, my name is Dmitry
I am very impressed with the project and it would be great to help with the development with contributions

I am an android developer with almost 5 years of experience in production
CV is attached
Kuzmin Dmitriy.pdf

What was done in this pull request:

  1. Removed unused code from IntroActivity
  2. Simplified layout of activity_intro
  3. Removed the dependency of the shimmering library
  4. Create helper method for wrapping a string into a color in html format (later you can be applied on other screens)

Do you need this kind of contribution? Maybe there is a list of urgent tasks that I can help with?

@soaryong-c
Copy link
Member

soaryong-c commented Jul 1, 2022

@qqdasdzxc
Thank you very much for your contribution.
Right now we're refactoring the whole thing, so it's hard to apply.
I will refer to the code you wrote when refactoring.

@soaryong-c soaryong-c closed this Jul 1, 2022
@qqdasdzxc
Copy link
Author

soaryong-c
I understand the pain of a big refactoring :D
So it would be cool to know when and how I can help by contributions, I have a great desire to help this project by development
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants