Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleService-Info.plist is missing for collaborators #194

Closed
albertopeam opened this issue Dec 9, 2022 · 4 comments
Closed

GoogleService-Info.plist is missing for collaborators #194

albertopeam opened this issue Dec 9, 2022 · 4 comments

Comments

@albertopeam
Copy link
Contributor

albertopeam commented Dec 9, 2022

Hi!

I have been checking and is possible to bypass for collaborators the absence of GoogleService-Info.plist without having to delete it manually every time we work in the project, it is annoying.

The solution is to remove the GoogleService-Info.plist from the CosmostationDev target and conditionally start firebase ONLY if the target is production. I don't think is the best way to fix it but at least is one way.

Another cleaner solution is to create separate files to deal with that so is not possible to make an error, ie:
Cosmostation target will have a file where we will do FirebaseApp.configure()
CosmostationDev target will have a file where we won't start firebase
No logic solution, safer and cleaner but a bit more complex. Not really complex, only more code

what do you think?
I would go with second one, but I am open :)

@soaryong-c
@wannabit-yongjoo

@albertopeam
Copy link
Contributor Author

PD: I can prepare any of the provided solutions :)

Let me know if you feel confortable with any of them

@soaryong-c
Copy link
Contributor

Both methods are fine.
I like the first one better because it's easier and we don't have to add a firebase project.
@wannabit-yongjoo @albertopeam

@albertopeam
Copy link
Contributor Author

PR created
#197

I have checked CosmostationDev target and it compiles OK
I have checked Cosmostation target but it doesn't compile for me(expected as GoogleService-Info.plist is missing on my side) please try to compile it to check that doesn't exist any issue

@soaryong-c
Copy link
Contributor

@albertopeam thank you! merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants