Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an API to drop specific table #11

Merged
merged 8 commits into from Dec 27, 2022
Merged

Conversation

Seidko
Copy link
Contributor

@Seidko Seidko commented Dec 25, 2022

descrpition of this pull request

Add an API to drop specific table.

the issue of this pull request aim to solve

This pull request aims to solve the problem of not being able to delete specific tables. Currently, minato only has an API for deleting all tables. this pull request adds the ability to delete specific tables.

The name of the API has been modified, which may be a breaking change.
packages/core/src/driver.ts Outdated Show resolved Hide resolved
packages/sqlite/src/index.ts Outdated Show resolved Hide resolved
packages/core/src/driver.ts Outdated Show resolved Hide resolved
packages/mongo/src/index.ts Outdated Show resolved Hide resolved
@Seidko
Copy link
Contributor Author

Seidko commented Dec 25, 2022

The work should be done now (?) you can test it now.

@Seidko Seidko requested a review from shigma December 25, 2022 04:56
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #11 (7c9130d) into master (e70617b) will decrease coverage by 0.13%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   97.82%   97.69%   -0.14%     
==========================================
  Files          24       24              
  Lines        4192     4205      +13     
  Branches      948      952       +4     
==========================================
+ Hits         4101     4108       +7     
- Misses         91       97       +6     
Impacted Files Coverage Δ
packages/mongo/src/index.ts 96.21% <50.00%> (-0.68%) ⬇️
packages/core/src/driver.ts 97.35% <60.00%> (-1.03%) ⬇️
packages/memory/src/index.ts 99.35% <83.33%> (-0.65%) ⬇️
packages/mysql/src/index.ts 96.53% <100.00%> (+<0.01%) ⬆️
packages/sqlite/src/index.ts 97.12% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shigma shigma merged commit b992b30 into cordiverse:master Dec 27, 2022
shigma added a commit that referenced this pull request Dec 27, 2022
Co-authored-by: Shigma <shigma10826@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants