Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air doesn't work with Colima #420

Closed
zachgrayio opened this issue May 1, 2023 · 7 comments
Closed

Air doesn't work with Colima #420

zachgrayio opened this issue May 1, 2023 · 7 comments

Comments

@zachgrayio
Copy link
Contributor

For air users hoping to use Colima as a replacement for Docker Desktop for Mac, unfortunately today the two don't work together, because file change events from Colima are sent as an event type that's filtered out by air, as is discussed here. abiosoft/colima#261 (comment)

To make this work, the chmod events from inotify via fsnotify need to be consumed by air and trigger a reload; today they are the 1 event type that is filtered out. #418 fixes this by removing the code which was filtering chmod/modified events.

Thanks!

@abdil1234
Copy link

hi, any update for this issue?

@xiantang
Copy link
Collaborator

xiantang commented Jun 17, 2023

sorry I use orbstack, I think it's better replacement for Docker Desktop for mac.

@zachgrayio
Copy link
Contributor Author

Looks like the fix was merged 15 days ago so this should be working in the next release or built from source on main branch?

@lorandfazakas
Copy link

lorandfazakas commented Jul 17, 2023

Hi @zachgrayio ,
As far as I can see the fix was reverted in v1.44.0 because it caused other issues.
As a result Air is still not working with Colima. Any plans to fix this in the near future?

@xiantang
Copy link
Collaborator

I think v1.46.0 should fixed

@markgeejw
Copy link

It’s still not working.

The chmod event is filtered away due to the validEvent check. @cosmtrek commented that the check can’t be removed due to the checksum in the PR. Can this be explained more so I could maybe work on it too.

@choznerol
Copy link

choznerol commented Dec 25, 2023

The existing poll option can workaround this perfectly for me.

// .air.yaml

+ # Use polling instead of fsnotify to workaround Colima comptibility issue:
+ # - https://github.com/cosmtrek/air/issues/420
+ poll = true
+ poll_interval = 500    # ms

P.s. M1, Sonoma 14.2, Colima at 0.6.7, air at devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants