Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does it need a custom install.sh? #434

Closed
coxley opened this issue Jun 20, 2023 · 3 comments · Fixed by #474
Closed

Why does it need a custom install.sh? #434

coxley opened this issue Jun 20, 2023 · 3 comments · Fixed by #474

Comments

@coxley
Copy link

coxley commented Jun 20, 2023

This works just fine, and is common for Go commands:

go run github.com/cosmtrek/air@latest --help

# or

go install github.com/cosmtrek/air@latest

Recommending people curl | sh always feels sketchy. After taking a quick look, I didn't see anything in it that was necessary. I can only assume that go install works the same across each platform it supports. Maybe you've found that isn't the case, and can ignore me. :)

@xiantang
Copy link
Collaborator

xiantang commented Oct 9, 2023

when we use go install github.com/cosmtrek/air@latest, we can't put version by air -v

@xiantang
Copy link
Collaborator

    info, ok := debug.ReadBuildInfo()

I suppose that I can use logic like this : https://github.com/mvdan/gofumpt/blob/master/internal/version/version.go#L37

@xiantang
Copy link
Collaborator

image
fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants