Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill_delay is in nanoseconds and not milliseconds as the example toml shows #436

Closed
varunbpatil opened this issue Jun 21, 2023 · 2 comments

Comments

@varunbpatil
Copy link

The example toml configuration file shows kill_delay as being in milliseconds

https://github.com/cosmtrek/air/blob/32675c4c222db3c187c2073340ccb3ff26ace1e2/air_example.toml#LL44C4-L44C4

but it is actually in nanoseconds which makes it unlike all the other time related configs which are in milliseconds.

@varunbpatil
Copy link
Author

Unfortunately, fixing this, although easy, is a backward incompatible change. So, I'm fine with simply updating the example toml configuration file.

@xiantang
Copy link
Collaborator

I think modifying the toml configuration file will suffice. Can you submit a PR?

@xiantang xiantang closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants