-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for runtime arguments #166
Conversation
The CodeCov upload failed but the actuall build is passing just for your info :) |
Any updates? |
I will take a look for this ticket. |
Any updates? I really need this feature! Thanks |
@xiantang |
I'll take a look in weekend. |
I could fix the PR so that it doesn't have any merge conflicts. |
go go go |
@lime008 any update? |
Adds support for providing runtime arguments for the built binary.
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 42.21% 42.84% +0.62%
==========================================
Files 5 5
Lines 829 838 +9
==========================================
+ Hits 350 359 +9
Misses 434 434
Partials 45 45
Continue to review full report at Codecov.
|
Don't merge this yet there's a few bugs still. I'll fix them and notify you. @xiantang |
This should work now. |
LGTM |
Adds support for providing runtime arguments for the built binary.
Fixes: #125
Could be used with #136 to also load arguments from the configuration.