Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for runtime arguments #166

Merged
merged 9 commits into from
Mar 12, 2022
Merged

Conversation

lime008
Copy link
Contributor

@lime008 lime008 commented Apr 25, 2021

Adds support for providing runtime arguments for the built binary.

Fixes: #125
Could be used with #136 to also load arguments from the configuration.

@lime008
Copy link
Contributor Author

lime008 commented Apr 25, 2021

The CodeCov upload failed but the actuall build is passing just for your info :)

@sysulq
Copy link

sysulq commented Jun 21, 2021

Any updates?

@xiantang
Copy link
Collaborator

I will take a look for this ticket.

@xiantang xiantang self-requested a review November 28, 2021 13:59
@credondocr
Copy link

Any updates? I really need this feature! Thanks

@dlsrb6342
Copy link

@xiantang
Any updates..?? This would be a nice feature.

@xiantang
Copy link
Collaborator

@xiantang Any updates..?? This would be a nice feature.

I'll take a look in weekend.

@lime008
Copy link
Contributor Author

lime008 commented Mar 10, 2022

I could fix the PR so that it doesn't have any merge conflicts.

@xiantang
Copy link
Collaborator

I could fix the PR so that it doesn't have any merge conflicts.

go go go

@xiantang
Copy link
Collaborator

@lime008 any update?

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #166 (8b98306) into master (9a18bdb) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   42.21%   42.84%   +0.62%     
==========================================
  Files           5        5              
  Lines         829      838       +9     
==========================================
+ Hits          350      359       +9     
  Misses        434      434              
  Partials       45       45              
Impacted Files Coverage Δ
runner/config.go 57.59% <100.00%> (+1.14%) ⬆️
runner/engine.go 25.40% <100.00%> (+0.60%) ⬆️
runner/util_linux.go 51.16% <100.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a18bdb...8b98306. Read the comment docs.

@lime008
Copy link
Contributor Author

lime008 commented Mar 11, 2022

Don't merge this yet there's a few bugs still. I'll fix them and notify you. @xiantang

@lime008
Copy link
Contributor Author

lime008 commented Mar 11, 2022

This should work now.

@xiantang xiantang merged commit 7058220 into air-verse:master Mar 12, 2022
@xiantang
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arguments are not supported
5 participants