Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration file extension from conf to toml #90

Merged
merged 5 commits into from
Aug 2, 2020

Conversation

178inaba
Copy link
Contributor

@178inaba 178inaba commented Jul 25, 2020

The configuration file is written in TOML format.
https://github.com/cosmtrek/air/blob/66e5eae8b270ea98ac50ac85f355d30c8607e1ca/air_example.conf#L1

So, by making the extension toml, you can apply syntax highlighting in TOML format and it will be easier to see.
https://github.com/cosmtrek/air/blob/3c279bf06a7243437e04b7f7c1ac679c63b123c7/air_example.toml

runner/config.go Outdated Show resolved Hide resolved
@xiantang
Copy link
Collaborator

we can both support old style use conf and support new style use toml.

@xiantang
Copy link
Collaborator

@178inaba

@178inaba 178inaba requested a review from xiantang July 25, 2020 17:28
@xiantang
Copy link
Collaborator

i will verify this pr soon.

@178inaba 178inaba requested a review from xiantang July 26, 2020 09:49
@xiantang
Copy link
Collaborator

xiantang commented Aug 2, 2020

LGTM

@xiantang xiantang merged commit 1e56563 into air-verse:master Aug 2, 2020
@xiantang
Copy link
Collaborator

xiantang commented Aug 2, 2020

thank you!

@178inaba 178inaba deleted the conf_to_toml branch August 2, 2020 08:20
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 19, 2021
As of air-verse/air#90, the preferred file
extension is .toml. The file format was always toml itself.
wxiaoguang pushed a commit to go-gitea/gitea that referenced this pull request Oct 19, 2021
As of air-verse/air#90, the preferred file
extension is .toml. The file format was always toml itself.
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
As of air-verse/air#90, the preferred file
extension is .toml. The file format was always toml itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants