Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming convention to camelCase #26

Closed
boris-jenicek opened this issue Dec 21, 2021 Discussed in #24 · 1 comment
Closed

Change naming convention to camelCase #26

boris-jenicek opened this issue Dec 21, 2021 Discussed in #24 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@boris-jenicek
Copy link
Owner

Discussed in #24

Originally posted by mgrtomasjurik December 1, 2021
Hello,
please could you adjust the code so it passes the lint code analyzer - lowerCamelCase rule?
Thank you 馃榾馃憤

Here is a Google typescript styleguide with the lowerCamelCase rule https://google.github.io/styleguide/tsguide.html#identifiers

In this case, the code for app.module.ts doesn't comply with the lowerCamelCase naming conventions for properties.
Instead of this:
// FROM HERE; NGX-AWESOME-POPUP
NgxAwesomePopupModule.forRoot({
ColorList: {
Success: '#3caea3', // optional
Info: '#2f8ee5', // optional
Warning: '#ffc107', // optional
...

It should be
// FROM HERE; NGX-AWESOME-POPUP
NgxAwesomePopupModule.forRoot({
colorList: {
success: '#3caea3', // optional
info: '#2f8ee5', // optional
warning: '#ffc107', // optional
etc....

Similar error appears when setting up the ToastNotificationInitializer
Instead of...
// Choose layout color type
newToastNotification.setConfig({
AutoCloseDelay: 5000, // optional
TextPosition: 'left', // optional
LayoutType: DialogLayoutDisplay.SUCCESS, // SUCCESS | INFO | NONE | DANGER | WARNING
ProgressBar: ToastProgressBarEnum.NONE, // INCREASE | DECREASE | NONE
ToastUserViewType: ToastUserViewTypeEnum.SIMPLE, // STANDARD | SIMPLE
...

...it should be:
// Choose layout color type
newToastNotification.setConfig({
autoCloseDelay: 5000, // optional
textPosition: 'left', // optional
layoutType: DialogLayoutDisplay.SUCCESS, // SUCCESS | INFO | NONE | DANGER | WARNING
progressBar: ToastProgressBarEnum.NONE, // INCREASE | DECREASE | NONE
toastUserViewType: ToastUserViewTypeEnum.SIMPLE, // STANDARD | SIMPLE
etc...

@boris-jenicek boris-jenicek added the enhancement New feature or request label Dec 21, 2021
@boris-jenicek boris-jenicek added this to the Version 3.0.0 milestone Dec 21, 2021
@boris-jenicek
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant