Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_socket_gmcp Denial of Service? #5

Closed
mindware opened this issue Aug 27, 2017 · 5 comments
Closed

write_socket_gmcp Denial of Service? #5

mindware opened this issue Aug 27, 2017 · 5 comments

Comments

@mindware
Copy link

I've noticed that executing the efun write_socket_gmcp(str1, str2); leads to a server crash. While I'm still getting familiar with GMCP, just the execution of the following is enough to trrigger the DoS:

exec write_socket_gmcp("test", "test");

Results in an immediate crash. The syslog notes the following:

Bad stack after evaluation. Was 37, expected 18446744073708813182, frame ends at 38.
Instruction 263, num arg 0 
Current object was d/Domainname/username/exec_obj
Aborted (core dumped)
Exit status:  134
@cotillion
Copy link
Owner

Thanks! Fixed now.

@mindware
Copy link
Author

mindware commented Sep 10, 2017

This is essentially fixed, however, when I run the above code, I don't see anything sent to the client. I've done packet sniffing on the client side to see if anything reaches the client, and it does not.

Any example of how one might use write_socket_gmcp effectively? @cotillion

@cotillion
Copy link
Owner

For anything to be sent the client needs to have negotiated GMCP support.
Both CMUD and Mudlet should be doing that however...

@mindware
Copy link
Author

I tested it in CMUD, and saw no packets. I'll try Mudlet next.

@mindware
Copy link
Author

mindware commented Oct 9, 2017

I just want to note that I didn't see any traffic. @cotillion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants