Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing stun_report_binding() call ? #1337

Open
jelmd opened this issue Dec 5, 2023 · 0 comments
Open

missing stun_report_binding() call ? #1337

jelmd opened this issue Dec 5, 2023 · 0 comments

Comments

@jelmd
Copy link
Contributor

jelmd commented Dec 5, 2023

Seems, that https://github.com/coturn/coturn/blob/master/src/server/ns_turn_server.c#L3916 is missing a stun_report_binding(ss, STUN_PROMETHEUS_METRIC_TYPE_RESPONSE, 0); call?

If I understand it correctly, right now handle_old_stun_command() counts the request, but not the response.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelmd