Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault due to stack overflow on log rotation #1455

Closed
dsmeytis opened this issue Mar 18, 2024 · 3 comments
Closed

Segmentation fault due to stack overflow on log rotation #1455

dsmeytis opened this issue Mar 18, 2024 · 3 comments

Comments

@dsmeytis
Copy link
Contributor

This commit #1221 causes segmentation fault due to the stack overflow.
TURN_LOG_FUNC macro calls set_rtpfile recursively if to_reset_log_file != 0
I believe it should be reverted or at least this logging line should be removed.

@eakraly
Copy link
Collaborator

eakraly commented Mar 19, 2024

Thank you @dsmeytis - that makes sense!

@ggarber
Copy link
Contributor

ggarber commented Mar 31, 2024

I prefer to remove the log then #1465

@eakraly
Copy link
Collaborator

eakraly commented Apr 5, 2024

There was a better way to solve it (reorder lines) but ok with this solution

@eakraly eakraly closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants