New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from JSHint to ESlint #60
Conversation
As these can be used in the viewquery excution
Conflicts: package.json
Thanks for the pull request!! To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements. To get this change in and collaborate in code review, please register on Gerrit and accept our CLA. The easiest way to do this is to follow the link below, sign in with your GitHub account and then follow through the steps provided on that page to sign an 'Individual' agreement: http://review.couchbase.org/#/settings/new-agreement. Note: Please contact us if you have any issues registering with Gerrit! If you have not signed our CLA within 7 days, the Pull Request will be automatically closed. ::SDKBOT/PR:no_cla |
Unfortunately it has been 7 days and we are still unable to confirm that you have signed our CLA. We sincerely appreciate your submission and hope that you will register and resubmit this Pull Request in the future! ::SDKBOT/PR:timeout |
Your robot appears to be broken when I go to gerrit it says Agreement already submitted. |
@brett19 can you look into what might be wrong with cb-sdk-robot? |
@corbinu Usually this means that your email address used for the commit author doesn't match what you have registered in Gerrit. If you want to take a look and fix that, that would be awesome. |
@brett19 I am sorry but I don't have an openID or a launchpadID and yes my email with github is different from from my git commit ID but we use Gitlab internally and don't want to mess up my work commits there either by changing it. I will see if there is something I can do, but this is not an easy process. |
@corbinu you should be able to add your email address at http://review.couchbase.org/#/settings/contact after logging in. It's also accessible from clicking on your name in the upper right, settings -> contact information. |
@ingenthr Thanks done! |
Recreated #62 |
ESlint is a newer pluggable linter that does both the job of JSHint and JSCS (the JSCS team has actually joined the ESLint team)
This PR is both a translation of the existing JSHint rules and a set of fixes based on issues found. It is structured so that if there is a rule you want changed it should be easy for me to rollback the commit and update the .eslintrc
Let me know if you have any questions or want any rule changes