Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential garbage of kvs pair during compactWriter.Mutate() #50

Open
steveyen opened this issue Sep 13, 2017 · 0 comments
Open

potential garbage of kvs pair during compactWriter.Mutate() #50

steveyen opened this issue Sep 13, 2017 · 0 comments

Comments

@steveyen
Copy link
Member

Saw this while doing a code review perusal, and wondering if the following allocates garbage...

pair := []uint64{opKlVl, uint64(keyStart)}

From: https://github.com/couchbase/moss/blob/master/store_compact.go#L534

If so, perhaps a pre-allocated pair can be held as part of the compactWriter and reused across multiple calls to compactWriter.Mutate()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steveyen