Skip to content

Commit

Permalink
don't try to force local ddoc replication on janitor pass.MB-4825
Browse files Browse the repository at this point in the history
The original idea was to ping ddoc replication srv that some vbuckets
may have been created. This was when we replicated ddocs to each
vbucket database.

It was broken even from day 0. Because it only touches local ddoc
replication srv. Even if this node doesn't run bucket yet/anymore.

Good thing is that it's not needed anymore. Because we don't replicate
ddocs to vbucket databases. So ddoc_replication_srv doesn't need any
notifications from janitor.

Change-Id: I759e457c984f94384eecfc673a7a0921111de99f
Reviewed-on: http://review.couchbase.org/13752
Tested-by: Aliaksey Kandratsenka <alkondratenko@gmail.com>
Reviewed-by: Aliaksey Artamonau <aliaksiej.artamonau@gmail.com>
  • Loading branch information
Aliaksey Kandratsenka authored and aartamonau committed Mar 2, 2012
1 parent 3910d86 commit 4e965f2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/ns_janitor.erl
Expand Up @@ -91,7 +91,6 @@ do_cleanup(Bucket, Options, Config) ->
%% pull. And we don't care if some of them are %% pull. And we don't care if some of them are
%% replicating from bucket members. %% replicating from bucket members.
ns_vbm_sup:set_replicas_dst(Bucket, NodesReplicas, Servers), ns_vbm_sup:set_replicas_dst(Bucket, NodesReplicas, Servers),
capi_ddoc_replication_srv:force_update(Bucket),
case Down of case Down of
[] -> [] ->
maybe_stop_replication_status(); maybe_stop_replication_status();
Expand Down

0 comments on commit 4e965f2

Please sign in to comment.