c4doc_enumerateAllDocs not honoring includeDeleted

[borrrden]

Unit test here

The all docs enumerator is including deleted documents no matter what.

[borrrden]

Guess I should put more details in here. The default options have includeDeleted as false. This is running on the CppTests target on Xcode 7 / El Capitan.

[snej]

Yeah, CBForest just uses the ForestDB include-deleted flag. Which isn't very useful for documents because we never delete them except on a purge. Our notion of deleted is just a flag in the metadata.

The Obj-C codebase does the filtering itself during the all-docs query; see CBL_ForestDBStorage.mm lines 632-634.

It would probably be useful to put this logic in the C API.

[borrrden]

It might be easier to leave it up to the other side, and just eliminate the includeDeleted parameter on the options. It only adds another line or two to C# to check (it has to check documents anyway in certain situations to make sure that design docs are not included)

[snej]

I'm already implementing it, actually. It's more efficient to skip docs at a lower level. While I'm at it, I should add the 'only-conflicts' flag too.