CXXCBC-346: Support for maxTTL value of -1 for collection 'no expiry' #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DemetrisChr
force-pushed
the
CXXCBC-436-max-ttl
branch
from
4f64b9d
to
726b4e9
Compare
DemetrisChr
force-pushed
the
CXXCBC-436-max-ttl
branch
from
726b4e9
to
e5cfe33
Compare
avsej
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The server has added support for the maxTTL value of -1 which is used to denote 'no expiry'
Changes
max_expiryin the collection management APIs (both core and public) fromuint32_ttoint32_tto allow setting it to -1. The server accepts values in the range [-1, 2,147,483,647] which can be represented by a 32-bit signed integer.errc::invalid_argumentwhen a value less than -1 is providedcreate_collectionandupdate_collectionwith different values formax_expiry