CXXCBC-449: Do not expose ASIO in public API #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsej
force-pushed
the
hide-asio-from-public-api
branch
16 times, most recently
from
1d801a8
to
e93a11e
Compare
DemetrisChr
reviewed
Jun 19, 2024
avsej
force-pushed
the
hide-asio-from-public-api
branch
from
e93a11e
to
d384e66
Compare
DemetrisChr
approved these changes
Jun 19, 2024
avsej
force-pushed
the
hide-asio-from-public-api
branch
7 times, most recently
from
4567349
to
d2325fe
Compare
passing empty vector might result in val.data() to be nullptr, which in turn is undefined behaviour, because memcpy expect non-null second argument
avsej
force-pushed
the
hide-asio-from-public-api
branch
from
d2325fe
to
91e8599
Compare
New implmentation of the collection cache had circular dependency that created memory leak, and memory allocated for collections component cannot be reclaimed
avsej
force-pushed
the
hide-asio-from-public-api
branch
2 times, most recently
from
6b1b691
to
87281e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.