Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contract] Add batchSubmission method #66

Closed
kazuakiishiguro opened this issue Jan 14, 2021 · 2 comments
Closed

[contract] Add batchSubmission method #66

kazuakiishiguro opened this issue Jan 14, 2021 · 2 comments
Assignees
@kazuakiishiguro
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
0.4

Comments

@kazuakiishiguro
Copy link
Member

No description provided.

@kazuakiishiguro kazuakiishiguro created this issue from a note in 0.4 (In Progress) Jan 14, 2021
@kazuakiishiguro kazuakiishiguro self-assigned this Jan 14, 2021
@kazuakiishiguro kazuakiishiguro added the enhancement New feature or request label Jan 14, 2021
@kazuakiishiguro
Copy link
Member Author

Added 53da5ea but test fail https://github.com/couger-inc/cream/actions/runs/484760523 from CreamFactory.test.ts

Looks like creating a new MACI contract (i.e. createCream() method of CreamFactory.sol) fail.

@kazuakiishiguro kazuakiishiguro added the invalid This doesn't seem right label Jan 14, 2021
@kazuakiishiguro kazuakiishiguro moved this from In Progress to To Do in 0.4 Jan 15, 2021
@kazuakiishiguro kazuakiishiguro moved this from To Do to In Progress in 0.4 Jan 19, 2021
@kazuakiishiguro
Copy link
Member Author

This was because of gas.
So uplifted gasLimit at d569934 and test went though.
However, need to work on reducing gas.

0.4 automation moved this from In Progress to Done Jan 19, 2021
@kazuakiishiguro kazuakiishiguro mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazuakiishiguro kazuakiishiguro

Labels
enhancement New feature or request invalid This doesn't seem right
Projects
0.4
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazuakiishiguro