feat: removing stray yaml dump #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes couler-proj#248 In that issue, @merlintang mentions this section can be removed.
|
/lgtm can we make this configurable, I am not sure whether other customers need to see the generated YAML for debugging? |
|
When I debug I manually call |
|
/lgtm |
|
/merge |
|
we can not merge on the web front end directly ? it is wired. |
terrytangyuan
approved these changes
Dec 10, 2021
|
@merlintang You need to click the diff and then click approve explicitly before you can merge it. |
|
thanks terry. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes #248
In that issue, @merlintang mentions this section can be removed.
Why are the changes needed?
Since this code is not contained in a method, it ends up being called outside of the context of couler/argo.
Does this PR introduce any user-facing change?
Only the reduction of output.
How was this patch tested?
Removed this and raised an exception and didn't get the yaml dump