Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

SDK meta data #20

Closed
erkanyildiz opened this issue Mar 14, 2017 · 7 comments
Closed

SDK meta data #20

erkanyildiz opened this issue Mar 14, 2017 · 7 comments
Assignees

Comments

@erkanyildiz
Copy link
Member

Request coming through JS SDK needs to send its own SDK meta data (version and name) for both iOS and Android.

Please edit these lines as below:
2.2 (or 2.2.1 if you plan to make a new release)
js-cordova-ios

iOS
https://github.com/Countly/countly-sdk-js/blob/master/src/ios/sdk/CountlyCommon.m#L19
https://github.com/Countly/countly-sdk-js/blob/master/src/ios/sdk/CountlyCommon.m#L20

Android
https://github.com/Countly/countly-sdk-js/blob/master/src/android/Countly.java#L52
https://github.com/Countly/countly-sdk-js/blob/master/src/android/Countly.java#L56

Until we come up with a better solution, manually overriding these values for each JS SDK release is ok.

@erkanyildiz
Copy link
Member Author

@trinisofttechnologies any progress with this one?

@trinisofttechnologies
Copy link
Contributor

Ohh, @erkanyildiz

This issue was never assigned to me.

@gorkem-cetin
Please assign this issue to me.
I am unable to assing this issue to myself.

@gorkem-cetin
Copy link
Contributor

Assigned.

@trinisofttechnologies
Copy link
Contributor

This changes are merged with dev-trinisoft branch

Will merge with master when we will make a release.

Thanks

@erkanyildiz
Copy link
Member Author

Neither on master nor on dev-trinisoft branch, SDK meta data is not updated as I specified.

@erkanyildiz erkanyildiz reopened this Aug 3, 2017
@trinisofttechnologies
Copy link
Contributor

ok, working on it.

@trinisofttechnologies
Copy link
Contributor

Now get it.

This is fixed in this commit.

1f5d040

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants