-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recordUserDetails should have it's counterpart to safely update custom properties #69
Comments
Hello, I will make sure the new SDK follows these new rules about user details soon: push and pushUnique methods on pseudo code should be ok, right? |
@erkanyildiz Documentation still looks not very obvious for me, sorry. Just to confirm:
is that correct? |
@garnett those two methods you listed will be used for custom properties and they will create an array property with many possible values, in first situation with possible duplicatevalues in second only with unique values |
I see, thanks @ar2rsawseen. Is there any approximate estimation of rolling this changes out? |
We can say within this month. |
This commit solves it: f2ac81f Soon we will merge. |
SDK should allow to query current user details
- (NSDictionary *)currentUserDetails
Use case for that:
[[Countly sharedInstance] recordUserDetails:@{kCLYUserCustom: @{@"prop": @1}}]
[[Countly sharedInstance] recordUserDetails:@{kCLYUserCustom: @{@"prop2": @"another"}}]
Which apparently wipes my first property.
Proposed approach is to query
currentUserDetails
and update this collection as necessary, then perform[[Countly sharedInstance] recordUserDetails:adjustedUserDetails]
Another possible solution is to iterate
kCLYUserCustom
inside SDK and update keys in the same fashion as predefined keys (e.g. name or birthday) -- checking if they are non-nil before updating.Would be happy to make PR, just let me know what approach is preferred.
The text was updated successfully, but these errors were encountered: