Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link click action did'nt track correctly #10

Closed
jianglinchun opened this issue Sep 6, 2016 · 1 comment
Closed

link click action did'nt track correctly #10

jianglinchun opened this issue Sep 6, 2016 · 1 comment

Comments

@jianglinchun
Copy link

jianglinchun commented Sep 6, 2016

html example:
`<a id='aa" href="http://github.com">

  • test
  • `

    The li element was treat as srcElement of the click event. So the id of the link was not tracked.
    Those helper methods have the same problem. Please improve:
    ……
    track_clicks
    track_links
    ……

    @ar2rsawseen
    Copy link
    Member

    ar2rsawseen commented Sep 6, 2016

    This issue should be fixed on development branch by 684e415 and c324f3d

    Note if you want to try development branch, then it currently does not parse user agent and does not send all metrics to server, metrics are post filled by web plugin on server side (which require some modifications on server)

    Will close issue after release, when development branch is merged

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants