Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update i18n_data to 0.10.0 #607

Closed
pravi opened this issue Dec 6, 2019 · 3 comments
Closed

Please update i18n_data to 0.10.0 #607

pravi opened this issue Dec 6, 2019 · 3 comments

Comments

@pravi
Copy link

pravi commented Dec 6, 2019

With i18n_data updated to 0.10.0 in gemspec, 4 tests fail, please fix the failures so newer version of i18n_data can be used.

$ bundle install
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
Using rake 13.0.1
Using concurrent-ruby 1.1.5
Using i18n 1.7.0
Using minitest 5.13.0
Using thread_safe 0.3.6
Using tzinfo 1.2.5
Using zeitwerk 2.2.2
Using activesupport 6.0.1
Using bundler 1.17.3
Fetching i18n_data 0.10.0 (was 0.8.0)
Installing i18n_data 0.10.0 (was 0.8.0)
Using sixarm_ruby_unaccent 1.2.0
Using unicode_utils 1.4.0
Using countries 3.0.0 from source at `.`
Using diff-lcs 1.3
Using geocoder 1.5.2
Using mini_portile2 2.4.0
Using money 6.13.6
Using nokogiri 1.10.7
Using retryable 3.0.5
Using rspec-support 3.9.0
Using rspec-core 3.9.0
Using rspec-expectations 3.9.0
Using rspec-mocks 3.9.0
Using rspec 3.9.0
Bundle complete! 9 Gemfile dependencies, 24 gems now installed.
Bundled gems are installed into `./vendor/bundle`
(debian-sid)pravi@vatapi:~/forge/debian/git/ruby-team/ruby-countries-upstream$ bundle exec rake
/usr/bin/ruby2.5 -I/home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/vendor/bundle/ruby/2.5.0/gems/rspec-core-3.9.0/lib:/home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/vendor/bundle/ruby/2.5.0/gems/rspec-support-3.9.0/lib /home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/vendor/bundle/ruby/2.5.0/gems/rspec-core-3.9.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb --color --warnings
/home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/lib/countries/country.rb:50: warning: method redefined; discarding old start_of_week
/home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/lib/countries/country.rb:8: warning: previous definition of start_of_week was here
Run options:
  include {:focus=>true}
  exclude {:perf=>true}

All examples were filtered out; ignoring {:focus=>true}
....../home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/vendor/bundle/ruby/2.5.0/gems/money-6.13.6/lib/money/money.rb:151: warning: method redefined; discarding old locale_backend=
/home/pravi/forge/debian/git/ruby-team/ruby-countries-upstream/vendor/bundle/ruby/2.5.0/gems/money-6.13.6/lib/money/money.rb:161: warning: method redefined; discarding old use_i18n=
.............................................................FF.......FF..................................................................................................

Failures:

  1) ISO3166::Country all_translated should return an alphabetized list of all country names translated to the selected locale
     Failure/Error: expect(countries.first).to eq('Afghanistan')
     
       expected: "Afghanistan"
            got: "Aruba"
     
       (compared using ==)
     # ./spec/country_spec.rb:325:in `block (3 levels) in <top (required)>'

  2) ISO3166::Country all_translated should return an alphabetized list of all country names in English if no locale is passed
     Failure/Error: expect(countries.first).to eq('Afghanistan')
     
       expected: "Afghanistan"
            got: "Aruba"
     
       (compared using ==)
     # ./spec/country_spec.rb:335:in `block (3 levels) in <top (required)>'

  3) ISO3166::Country translations should return an hash of all country names translated to the selected locale
     Failure/Error: expect(countries.first[0]).to eq('AF')
     
       expected: "AF"
            got: "AW"
     
       (compared using ==)
     # ./spec/country_spec.rb:406:in `block (3 levels) in <top (required)>'

  4) ISO3166::Country translations should return an hash of all country names in English if no locale is passed
     Failure/Error: expect(countries.first[0]).to eq('AF')
     
       expected: "AF"
            got: "AW"
     
       (compared using ==)
     # ./spec/country_spec.rb:416:in `block (3 levels) in <top (required)>'

Finished in 4.12 seconds (files took 0.25584 seconds to load)
176 examples, 4 failures

Failed examples:

rspec ./spec/country_spec.rb:321 # ISO3166::Country all_translated should return an alphabetized list of all country names translated to the selected locale
rspec ./spec/country_spec.rb:331 # ISO3166::Country all_translated should return an alphabetized list of all country names in English if no locale is passed
rspec ./spec/country_spec.rb:403 # ISO3166::Country translations should return an hash of all country names translated to the selected locale
rspec ./spec/country_spec.rb:413 # ISO3166::Country translations should return an hash of all country names in English if no locale is passed

@larouxn
Copy link

larouxn commented Jan 31, 2020

Strangely I can't seem to replicate this. Seems to work fine with i18n_data v0.10.0. Even stranger, the test fixes seems to be from last March: #572. 🤷‍♂
Screen Shot 2020-01-30 at 22 43 54

@rposborne
Copy link
Collaborator

@pravi can you provide a steps to reproduce? I think this may be something outside the scope of the repo causing something to fail. Timezone? Country Code?

It is possible this project has picked up some intermittent test fails.

@pmor
Copy link
Member

pmor commented Nov 13, 2020

I just looked at this, and the latest release already used 0.10.0, so I'm closing this.

@pmor pmor closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants