Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous data for countries that span continental boundaries #780

Open
brandondrew opened this issue Nov 18, 2022 · 1 comment
Open

Erroneous data for countries that span continental boundaries #780

brandondrew opened this issue Nov 18, 2022 · 1 comment

Comments

@brandondrew
Copy link

Continental boundaries are not as clear as we might like. If we accept the conventional division between Europe and Asia, then both Russia and Turkey cross the boundary, with by far the greater part of their land in Asia.

And yet this gem lists both of them as being in Europe.

require 'countries/global'
turkey = Country['TR']
russia = Country['RU']
turkey.continent # => "Europe"
russia.continent # => "Europe"

For Russia this might make sense, since the bulk of the population (if I'm not mistaken) is in Europe, but for Turkey this is most certainly wrong. The vast majority of the Turkish people are very definitely in Asia, and the portion of the country's land that is in Europe is absolutely tiny.

East Thrace or Eastern Thrace, also known as Turkish Thrace or European Turkey, is the part of Turkey that is geographically a part of Southeast Europe. It accounts for 3.4% of Turkey's land area but comprises 15% of its total population.
-- https://en.wikipedia.org/wiki/East_Thrace

Ideally I think it makes more sense to have a :continents key which returns an array. For backward compatibility it would make sense to keep :continent, but it should show the primary continent, preferably by some criteria that depends on measurable data rather than someone's preference.

I'd be happy to submit PRs for correcting the :continent to reflect primary continent if there's an openness to it. If so, the main question would be do we want to use land area or population to determine which continent is primary?

The other one is a bit more complicated, and therefore might perhaps make sense to do in stages, as we would run into questions like "Is French Guiana actually a part of France?" (I'm told it is by a geographic expert I trust, but it may not be as clear-cut as Russia and Turkey.)

@pmor
Copy link
Member

pmor commented Dec 12, 2022

Yeah, I think you have a good idea there, I'll think about this a bit more and try to come up with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants