Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block label differs in implementation and documentation #49

Closed
wilhelmmailaender opened this issue Oct 8, 2020 · 1 comment · Fixed by #104
Closed

block label differs in implementation and documentation #49

wilhelmmailaender opened this issue Oct 8, 2020 · 1 comment · Fixed by #104
Labels
documentation Improvements or additions to documentation

Comments

@wilhelmmailaender
Copy link
Contributor

In the documentation the label is optional for the server, api, spa and files block.

But the implementation differs. The label is required for server, and not allowed for api, spa and files. Other blocks may be also differ between implementation and documentation.

The implementation should make the label optional for all blocks, as it is in the documentation.

@malud malud added the documentation Improvements or additions to documentation label Oct 9, 2020
@malud
Copy link
Collaborator

malud commented Oct 9, 2020

We should adapt the docs for now. The server label is required and not designated for files spa and api (currently).

/cc @filex

@malud malud changed the title label differs in implementation and documentation block label differs in implementation and documentation Oct 9, 2020
@malud malud linked a pull request Jan 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants