Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve -t completeness issue #661

Closed
wisechengyi opened this issue Sep 22, 2017 · 3 comments
Closed

resolve -t completeness issue #661

wisechengyi opened this issue Sep 22, 2017 · 3 comments

Comments

@wisechengyi
Copy link
Collaborator

wisechengyi commented Sep 22, 2017

Hi,

I've noticed that when two artifacts with share a set of dependencies, resolve -t will not show one of them.

$ ./coursier resolve -t org.apache.avro:avro:1.7.4
  Result:
└─ org.apache.avro:avro:1.7.4
   ├─ com.thoughtworks.paranamer:paranamer:2.3
   ├─ org.apache.commons:commons-compress:1.4.1
   │  └─ org.tukaani:xz:1.0
   ├─ org.codehaus.jackson:jackson-core-asl:1.8.8
   ├─ org.codehaus.jackson:jackson-mapper-asl:1.8.8
   │  └─ org.codehaus.jackson:jackson-core-asl:1.8.8
   ├─ org.slf4j:slf4j-api:1.6.4
   └─ org.xerial.snappy:snappy-java:1.0.4.1

which includes

   ├─ org.apache.commons:commons-compress:1.4.1
   │  └─ org.tukaani:xz:1.0

but if I do

./coursier resolve -t org.apache.avro:avro:1.7.4 org.apache.commons:commons-compress:1.4.1
 Result:
├─ org.apache.avro:avro:1.7.4
│  ├─ com.thoughtworks.paranamer:paranamer:2.3
│  ├─ org.apache.commons:commons-compress:1.4.1
│  │  └─ org.tukaani:xz:1.0
│  ├─ org.codehaus.jackson:jackson-core-asl:1.8.8
│  ├─ org.codehaus.jackson:jackson-mapper-asl:1.8.8
│  │  └─ org.codehaus.jackson:jackson-core-asl:1.8.8
│  ├─ org.slf4j:slf4j-api:1.6.4
│  └─ org.xerial.snappy:snappy-java:1.0.4.1
└─ org.apache.commons:commons-compress:1.4.1
          // why is there nothing over here?

the root level org.apache.commons:commons-compress:1.4.1 does not have its dependencies printed out.

  1. Is that expect?
  2. If yes, can I force coursier to print out all transitive dependencies from the roots specified?

Thanks,
Yi

@wisechengyi
Copy link
Collaborator Author

wisechengyi commented Sep 22, 2017

which is also inconsistent with the following result that root will have the transitive dependencies.

$ ./coursier resolve -t -n 12  net.java.dev.jets3t:jets3t:0.9.0   
  Result:
└─ net.java.dev.jets3t:jets3t:0.9.0
   ├─ com.jamesmurty.utils:java-xmlbuilder:0.4
   ├─ commons-codec:commons-codec:1.4
   ├─ commons-logging:commons-logging:1.1.1
   ├─ org.apache.httpcomponents:httpclient:4.1.2 // then i put this as one of the roots to resolve
   │  └─ org.apache.httpcomponents:httpcore:4.1.2
   └─ org.apache.httpcomponents:httpcore:4.1.2
$ ./coursier resolve -t -n 12  net.java.dev.jets3t:jets3t:0.9.0   org.apache.httpcomponents:httpclient:4.1.2
  Result:
├─ net.java.dev.jets3t:jets3t:0.9.0
│  ├─ com.jamesmurty.utils:java-xmlbuilder:0.4
│  ├─ commons-codec:commons-codec:1.4
│  ├─ commons-logging:commons-logging:1.1.1
│  ├─ org.apache.httpcomponents:httpclient:4.1.2
│  │  └─ org.apache.httpcomponents:httpcore:4.1.2
│  └─ org.apache.httpcomponents:httpcore:4.1.2
└─ org.apache.httpcomponents:httpclient:4.1.2
   ├─ commons-codec:commons-codec:1.4
   ├─ commons-logging:commons-logging:1.1.1
   └─ org.apache.httpcomponents:httpcore:4.1.2

@wisechengyi
Copy link
Collaborator Author

wisechengyi commented Oct 12, 2017

HI @alexarchambault , I put up a PR #671 for this. It basically will output the complete tree transitively. Given the behavior before was explicitly excluding the jars that have already been printed, was that intended and should I add it behind an option?

@wisechengyi
Copy link
Collaborator Author

fixed by 07e985b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants