Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to node 16 #281

Closed
BalmungSan opened this issue Oct 10, 2022 · 1 comment · Fixed by #283
Closed

Upgrade to node 16 #281

BalmungSan opened this issue Oct 10, 2022 · 1 comment · Fixed by #283

Comments

@BalmungSan
Copy link
Contributor

BalmungSan commented Oct 10, 2022 •
edited

Actions using Node 12 are considered deprecated and encouraged to upgrade to Node 16.
For reference: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

I wonder if all that is needed is just changing this line.

runs:
-  using: 'node12'
+  using: 'node16'
  main: 'dist/index.js'

And refreshing the package-lock.json using Node 16.

If so, I am more than happy to help.
But, if something else is required I would need assistance / guidance.

See also: coursier/cache-action#410
@BalmungSan BalmungSan mentioned this issue Oct 10, 2022
Closed
@alexarchambault
Copy link
Member

@BalmungSan Sure, feel free to send PRs bumping Node.

@BalmungSan BalmungSan mentioned this issue Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Node 16 BalmungSan/setup-action
2 participants
@alexarchambault @BalmungSan