New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peek_cjsg() returns error when there are 0 results #23

Closed

jtrecenti opened this issue May 26, 2018 · 1 comment

Assignees

Labels

bug

Member

jtrecenti commented May 26, 2018

Example

n_pags <- esaj::peek_cjsg(query = "", subjects = "14")  
#> There are 169 pages to download
#> This should take around 1.4 minutes
n_pags                                                  
#> [1] 167
                                                        
n_pags <- esaj::peek_cjsg(query = "", subjects = "5944")
#> Error in ceiling(.): non-numeric argument to mathematical function

I think it should throw a message and return 0L

Also the result is always numeric. it should be an integer.

jtrecenti assigned clente

jtrecenti added the bug label

Contributor

clente commented May 29, 2018

[2e14098] esaj::peek_cjsg() now reports that there are no pages to download.

clente closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment