Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pangolin output missing failed qc samples #181

Closed
santoshe1 opened this issue May 3, 2021 · 1 comment
Closed

Pangolin output missing failed qc samples #181

santoshe1 opened this issue May 3, 2021 · 1 comment

Comments

@santoshe1
Copy link

Hi,

Versions - pangolin v2.4 and pangoLEARN 2021-04-28

I observe in the final pangolin output csv file, it is missing to report the actual failed qc samples and its showing redundant results such as:

barcode90,B.1,0.0,2021-04-28,v1.1.23,passed_qc,
barcode90,None,0,2021-04-28,v1.1.23,fail,failed_to_map
barcode90,None,0,2021-04-28,v1.1.23,fail,failed_to_map
barcode90,None,0,2021-04-28,v1.1.23,fail,failed_to_map
barcode90,None,0,2021-04-28,v1.1.23,fail,failed_to_map
barcode90,None,0,2021-04-28,v1.1.23,fail,failed_to_map

Whereas the failed were other barcodes and its not reported in the csv. This looks a possible bug, Could you fix the issue?

@aineniamh
Copy link
Member

Hi @santoshe1, I've just tracked down the bug and pushed the changes to the master branch, and will be included in the next release later today. Thanks so much for spotting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants