Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child config should have priority over parent config #46

Merged
merged 1 commit into from Feb 5, 2019
Merged

Child config should have priority over parent config #46

merged 1 commit into from Feb 5, 2019

Conversation

julienduchesne
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 703

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.656%
Totals Coverage Status
Change from base Build 700: 0.0%
Covered Lines: 142
Relevant Lines: 907
💛 - Coveralls

AbdulRahmanAlHamali
AbdulRahmanAlHamali approved these changes Feb 5, 2019
View reviewed changes
config.go Show resolved Hide resolved
jocgir
jocgir approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@jocgir jocgir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was supposed to be already the case. Probably broken with some rework,

@julienduchesne julienduchesne merged commit 3e8cdea into master Feb 5, 2019
@julienduchesne julienduchesne deleted the child-config-overwrite branch February 5, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdulRahmanAlHamali AbdulRahmanAlHamali AbdulRahmanAlHamali approved these changes

@jocgir jocgir jocgir approved these changes

@dblanchette dblanchette Awaiting requested review from dblanchette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julienduchesne @coveralls @AbdulRahmanAlHamali @jocgir