Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --non-interactive option to run Docker without "-it" flags #50

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

dblanchette
Copy link
Contributor

Needed to run tgf as part of unit tests (with pytest for example)

main.go Outdated
@@ -145,6 +147,7 @@ func main() {
app.Switch("no-temp", "Disable the mapping of the temp directory (alias --nt)").BoolVar(&noTemp)
app.Switch("refresh-image", "Force a refresh of the docker image (alias --ri)").BoolVar(&refresh)
app.Switch("local-image", "If set, TGF will not pull the image when refreshing (alias --li)").BoolVar(&useLocalImage)
app.Switch("interactive", "If set, docker will be launched in interactive mode, i.e. the -it flag will be passed to the docker cli (alias --it) or set "+envPSPath).Envar(envInteractive).BoolVar(&dockerInteractive)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envInteractive

@coveralls
Copy link

coveralls commented Apr 19, 2019

Pull Request Test Coverage Report for Build 727

  • 0 of 14 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 16.249%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 3 0.0%
docker.go 0 5 0.0%
arguments.go 0 6 0.0%
Totals Coverage Status
Change from base Build 720: -0.2%
Covered Lines: 149
Relevant Lines: 917

💛 - Coveralls

@jocgir jocgir merged commit 6bbb42a into master Apr 19, 2019
@jocgir jocgir deleted the feature/DT-1515-docker-non-interactive branch May 1, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants