Fix bug when no unmanaged args were given #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added tests for the CLI argument parsing logic + aliases
julienduchesne
commented
May 1, 2019
| @@ -297,6 +147,3 @@ func validateVersion(version string) bool { | |||
|
|
|||
| func printError(format string, args ...interface{}) { ErrPrintln(errorString(format, args...)) } | |||
| func printWarning(format string, args ...interface{}) { ErrPrintln(warningString(format, args...)) } | |||
|
|
|||
| var warningString = color.New(color.FgYellow).SprintfFunc() | |||
There was a problem hiding this comment.
Moved up with the other vars
| link := color.New(color.FgHiBlue, color.Italic).SprintfFunc() | ||
| bold := color.New(color.Bold).SprintfFunc() | ||
|
|
||
| descriptionTemplate.Execute(&descriptionBuffer, map[string]interface{}{ |
There was a problem hiding this comment.
moved to cli.go
|
|
||
| // Environment variables | ||
| const ( |
There was a problem hiding this comment.
moved to cli.go
arguments.go
Outdated
| @@ -1,120 +0,0 @@ | |||
| package main | |||
There was a problem hiding this comment.
moved to cli.go
jocgir
reviewed
May 1, 2019
go.mod
Outdated
| @@ -12,7 +12,7 @@ require ( | |||
| github.com/aws/aws-sdk-go v1.16.12 | |||
| github.com/blang/semver v0.0.0-20180723201105-3c1074078d32 | |||
| github.com/cheekybits/is v0.0.0-20150225183255-68e9c0620927 // indirect | |||
| github.com/coveo/gotemplate v2.7.6+incompatible // indirect | |||
| github.com/coveo/gotemplate v2.7.6+incompatible | |||
There was a problem hiding this comment.
gotemplate or this modification?
There was a problem hiding this comment.
OK, it is because terragrunt is not still updated to go modules
There was a problem hiding this comment.
I mean the v2.7.6+incompatible ...
Pull Request Test Coverage Report for Build 782
💛 - Coveralls |
jocgir
previously approved these changes
May 1, 2019
jocgir
previously approved these changes
May 1, 2019
cli.go
Outdated
| @@ -240,20 +244,20 @@ func (app *ApplicationArguments) parseArguments() (*CliOptions, []string) { | |||
| if extraArgs, ok := os.LookupEnv(envArgs); ok { | |||
| os.Args = append(os.Args, strings.Split(extraArgs, " ")...) | |||
| } | |||
| managed, unmanaged := app.SplitManaged(os.Args) | |||
| must(app.Parse(managed)) | |||
| app.managedArgs, app.unmanagedArgs = app.SplitManaged(os.Args) | |||
There was a problem hiding this comment.
The SplitManaged should then modify directly the parameters.
You should instead override the Parse method. I'll do it in your branch.
|
Nice! Ready to merge? |
|
It is up to you now. |
jocgir
approved these changes
May 2, 2019
|
I'll merge it but not release 1.20.0 now. I may have some other fixes to do. My functional tests are still not working, but I'm making progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the CLI arguments structure. Some were function specific, some were global, it was weird. Now all are global and contained within a class. Ideally, it wouldn't be global and it would be passed around but that would require too many modifications for now. Maybe another time.
Also added tests for the CLI argument parsing logic + aliases