Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in relevant lines calculation between python versions 3.7 and greater #108

Open
jtroussard opened this issue Jan 2, 2022 · 1 comment

Comments

@jtroussard
Copy link

Description

Our pipeline runs coverallsapp action in parallel with several different versions of python. Noticed that after making a non-functional change to a file, (removed comment) our coveralls check was failing the build for a -0.0% decrease.

Difference Between Versions

Search results in a small difference the relevant lines are calculated between python versions:

3.7
37

3.8
38

The difference between the to are the method declaration lines. 3.6 and 3.7 seem to leave it out, while 3.8 and beyond include the line as "relevant". This is the only significant difference I can find between the passing coveralls checks (3.6, 3.7) and the failing checks, (3.8, 3.9)

Questions

  • Can anyone shed any light on this issue?
  • Is there a workaround besides increasing the failure threshold?
  • Is this a bug?
  • Am I misdiagnosing my coverage failures?
@jtroussard
Copy link
Author

jtroussard commented Jan 4, 2022

Wanted to add a screenshot of the coveralls github action results to further illustrate

Screen Shot 2022-01-04 at 2 49 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant