Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage result uses comma instead of dot for decimals #1263

Closed
boldt opened this issue Dec 2, 2021 · 2 comments · Fixed by #1264
Closed

Coverage result uses comma instead of dot for decimals #1263

boldt opened this issue Dec 2, 2021 · 2 comments · Fixed by #1264
Assignees
Labels
bug Something isn't working

Comments

@boldt
Copy link

boldt commented Dec 2, 2021

When I run dotnet coverlet on an english Linux machine, the result uses a dot:

+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 35.41% | 24.31% | 51.41% |
+---------+--------+--------+--------+

When I run the same on a german Windows, the result uses a comma:

+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 35,41% | 24,31% | 51,41% |
+---------+--------+--------+--------+

I tried to set $Env:DOTNET_CLI_UI_LANGUAGE = "en", but it still uses the comma.

Is there any way to configure the output format?

@daveMueller
Copy link
Collaborator

Thanks for reporting this. I would suggest we use invariant culture here because the rest of our cli output is also english.

image

@daveMueller daveMueller self-assigned this Dec 3, 2021
@daveMueller daveMueller added the bug Something isn't working label Dec 3, 2021
@boldt
Copy link
Author

boldt commented Dec 3, 2021

Thanks for the quick response and (upcoming) fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants