Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html report as an output format #90

Closed
coderpatros opened this issue May 7, 2018 · 4 comments
Closed

Add html report as an output format #90

coderpatros opened this issue May 7, 2018 · 4 comments

Comments

@coderpatros
Copy link
Contributor

coderpatros commented May 7, 2018

Is this an option that you would like added @tonerdo? I'd be happy to do some work in this space. I quite like the reports generated by coverage-viewer. It is written in node.js so it would need to be ported over to avoid the node.js dependency.

Edit: And I just double checked the licence for coverage-viewer and it is MIT as well.

@hunterjm
Copy link
Contributor

hunterjm commented May 7, 2018

@patros - I've done some work to ReportGenerator (danielpalme/ReportGenerator#130) that would make this feature a stones throw away if/when it gets merged and pushed up to NuGet. All it would involve is including a new package reference and a little bit of code to the CoverageResultTask. I've already got it hooked up in a custom build.

The advantage would be that coverlet wouldn't have to maintain the HTML report generation, but could simply update the package when new features are available.

@coderpatros
Copy link
Contributor Author

@hunterjm good point about having to maintain the html report generation. With a few good options maintained outside of this project the next question is whether Toni wants to include human readable output formats or to let the user choose their html generator of choice.

@tonerdo
Copy link
Collaborator

tonerdo commented May 8, 2018

@patros I'm currently leaning towards letting the user choose their html generator of choice. But definitely something to think about

@coderpatros
Copy link
Contributor Author

@tonerdo I'll close this issue. It can always be reopened if you start to lean the other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants