Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Calendar component as per mock up in design directory #14

Closed
tesla809 opened this issue Mar 14, 2020 · 2 comments · Fixed by #207
Closed

Create Calendar component as per mock up in design directory #14

tesla809 opened this issue Mar 14, 2020 · 2 comments · Fixed by #207
Assignees
Labels
Frontend Issues pertaining to the Front end team good first issue Good for newcomers v2 For our beta release

Comments

@tesla809
Copy link
Contributor

Task
Use the mockup in the design directory to create a separate component for the calendar.

What done looks like
We have a Calendar.js component in /components.
We have a .css file to style the Calendar.js component in /css.

Design considerations
We have decided to use regular CSS files to keep things simple for now. This allows for more contributors and less time to upskill to contribute.

Once MVP is done the team can discuss if we want to transition it to styled-components or something like CSS modules.

Folder paths
CSS is located in /client/src/css
Components are located in /client/src/components

Style guide for CSS files:

Naming convention:
Component -> Calendar.js
CSS file -> Calendar.css

To avoid naming collisions:
prefix class names with the name of component and link with kebab case.
Class name -> .Calendar-header { ... }

How to handle state:
If you can use redux, use it.
Create action and reducer with an appropriate name.

testing
No need to worry about testing for now.
If you choose to add tests, please place in client/src/tests

@tesla809 tesla809 added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 14, 2020
@tesla809 tesla809 added this to To do in CoronaTracker Kanban Board via automation Mar 14, 2020
@tesla809
Copy link
Contributor Author

@akilhylton create Calendar.js and test using react-calendar@3.0.0.

Will import into App.js and style up.

@tesla809 tesla809 moved this from To do to In progress in CoronaTracker Kanban Board Mar 15, 2020
@SomeMoosery SomeMoosery added this to In progress in Frontend Components Mar 22, 2020
@awu556 awu556 added the Frontend Issues pertaining to the Front end team label Mar 24, 2020
@SomeMoosery SomeMoosery added the v2 For our beta release label Mar 25, 2020
@SomeMoosery SomeMoosery moved this from In progress to To do in CoronaTracker Kanban Board Mar 25, 2020
@SomeMoosery SomeMoosery moved this from In progress to To do in Frontend Components Mar 25, 2020
@pavel-ilin
Copy link

I'm currently working on this issue.

@awu556 awu556 moved this from To do to In progress in Frontend Components Mar 25, 2020
@SomeMoosery SomeMoosery moved this from To do to In progress in CoronaTracker Kanban Board Mar 25, 2020
@SomeMoosery SomeMoosery removed the help wanted Extra attention is needed label Mar 26, 2020
CoronaTracker Kanban Board automation moved this from In progress to Done Mar 26, 2020
Frontend Components automation moved this from In progress to Done Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issues pertaining to the Front end team good first issue Good for newcomers v2 For our beta release
Development

Successfully merging a pull request may close this issue.

6 participants