Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Table.js with React-Bootstrap's Table component to display dummy data from CORONATRACKER UI - Health Log - Show Me More.png #80

Closed
tesla809 opened this issue Mar 18, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers V1 Version 1- education

Comments

@tesla809
Copy link
Contributor

Task
Create Table.js with React-Bootstrap's Table component to display dummy data from CORONATRACKER UI - Health Log - Show Me More.png
Use either react-bootstrap's table component
See: CORONATRACKER UI - Health Log - Show Me More.png

What done looks like:

  1. Add comments to explain code.
  2. Use React-Bootstrap's Table component
  3. Style it according to the style guide using themePalette.css in /css folder.
  4. Import themePalette.css into the file and use appropriate classes. Do not try to redo styling from scratch. Please save time.

Design considerations:
We have decided to use regular CSS files to keep things simple for now. This allows for more contributors and less time to upskill to contribute.

Once MVP is done the team can discuss if we want to transition it to styled-components or something like CSS modules.

Folder paths
CSS is located in /client/src/css
Components are located in /client/src/components

Style guide for CSS files:
Naming convention:
Component -> Table.js
CSS file -> Table.css

To avoid naming collisions:
prefix class names with the name of component and link with kebab case.
Class name -> .Table-header { ... }
Although, we do not foresee the need to create custom CSS since React-Bootstrap and themePalette.css will take care of it. If so, please follow the style guide.

How to handle state:
Add dummy data for now. Redux will be added later.

Testing:
No need to worry about testing for now.
If you choose to add tests, please place in client/src/tests

@tesla809 tesla809 added the good first issue Good for newcomers label Mar 18, 2020
@tesla809 tesla809 added this to To do in CoronaTracker Kanban Board via automation Mar 18, 2020
@SomeMoosery SomeMoosery added the enhancement New feature or request label Mar 21, 2020
@SomeMoosery SomeMoosery moved this from To do to In review in CoronaTracker Kanban Board Mar 21, 2020
SomeMoosery pushed a commit that referenced this issue Mar 21, 2020
@SomeMoosery SomeMoosery added this to In progress in Frontend Components Mar 22, 2020
@awu556 awu556 moved this from In progress to Done in Frontend Components Mar 22, 2020
CoronaTracker Kanban Board automation moved this from In review to Done Mar 22, 2020
@tesla809 tesla809 added the V1 Version 1- education label Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers V1 Version 1- education
Development

No branches or pull requests

3 participants