Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Slider.js component #82

Closed
tesla809 opened this issue Mar 18, 2020 · 0 comments
Closed

Create Slider.js component #82

tesla809 opened this issue Mar 18, 2020 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tesla809
Copy link
Contributor

tesla809 commented Mar 18, 2020

Task
Create Slider.js component.
See the following for the design.

It is the slider in the view.

What done looks like:

  1. You created the Slider.js component as per the instruction above.
  2. Add comments to explain code if necessary.
  3. We have Slider.js component in /components.
  4. You have used the themePalette.css file and the corresponding classes to style the button and imported at the top of the file BEFORE your component.
  5. Create a Slider.css file. Also Use themePalette.css for styling.
  6. You have used the name Slider.js for the component.

Design considerations:
We have decided to use regular CSS files to keep things simple for now. This allows for more contributors and less time to upskill to contribute.

Once MVP is done the team can discuss if we want to transition it to styled-components or something like CSS modules.

Folder paths
CSS is located in /client/src/css
Components are located in /client/src/components

Style guide for CSS files:
Naming convention:
Component -> Slider.js
CSS file -> Use themePalette.css and create a Slider.css file.

How to handle state:
If you can use redux, use it.
Create action and reducer with an appropriate name.

Testing:
No need to worry about testing for now.
If you choose to add tests, please place in client/src/tests

@tesla809 tesla809 added this to To do in CoronaTracker Kanban Board via automation Mar 18, 2020
@tesla809 tesla809 added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 18, 2020
@k105la k105la self-assigned this Mar 19, 2020
@tesla809 tesla809 assigned dinadeljanin and k105la and unassigned k105la and dinadeljanin Mar 19, 2020
@k105la k105la closed this as completed Mar 20, 2020
CoronaTracker Kanban Board automation moved this from To do to Done Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

No branches or pull requests

3 participants