Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize text sizes, chart height on mobile web #117

Closed
rachelrf opened this issue Mar 22, 2020 · 8 comments
Closed

Optimize text sizes, chart height on mobile web #117

rachelrf opened this issue Mar 22, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@rachelrf
Copy link
Contributor

No description provided.

@zjrosen1
Copy link
Contributor

@zjrosen1 zjrosen1 added the enhancement New feature or request label Mar 22, 2020
@rachelrf rachelrf assigned rachelrf and arjun-ltse and unassigned rachelrf Mar 22, 2020
@arjun-ltse arjun-ltse removed their assignment Mar 23, 2020
@igorkofman
Copy link
Collaborator

How's this going? I know @arjun-ltse started on this as well but not sure if it's being actively worked on. Can you guys sync @arjun-ltse @rachelrf ?

@rachelrf
Copy link
Contributor Author

sure thing. @arjun-ltse, do you want to get your change into a good state and land it, and then I can pick up this issue from there?

@arjun-ltse
Copy link
Contributor

@rachelrf I'm very limited with time this week. I will have an hour or two tonight. I'll actually try to break it out into smaller PRs that are more focused and can be taken over individually.

@arjun-ltse
Copy link
Contributor

arjun-ltse commented Mar 25, 2020

@rachelrf @zjrosen1 Unfortunately not going to be able to get to this. 😞

The biggest issue I was trying to resolve is the endorsements grid. I can create a new ticket. But can't fix, tonight at least.

@rachelrf
Copy link
Contributor Author

@arjun-ltse I can work on this tomorrow evening, just so we're on the same page, can you update with:

  1. the status of anything in progress, if you already got started
  2. whether you have time to keep working on it or would rather hand it off

Either is fine, but do please let me know before tomorrow evening so that we can avoid any duplicate work :)

@arjun-ltse
Copy link
Contributor

@rachelrf Thanks for that. And apologies for not being able to continue on this.

For 1:
I'd suggest to close my PR and start fresh. I realize it wasn't clear what this task entails regarding the design (eg. Is part of this to wrap the page titles in black boxes)? My PR got too convoluted and it was trying to tackle too many things:

None of which were resolved enough to merge.

You can review the PR for reference. You can see I was trying to use a global value for breakpoints. But the reality is that there are 4 different style systems going on here (inline, SCSS, materialUI, and CSS).

Would be good to check with @szhu about #149 to avoid duplicate work.

For 2:
I don't have time this week to keep working on this, so you can for sure take this over!

@szhu
Copy link
Contributor

szhu commented Mar 29, 2020

@rachelrf fyt I made #261 to make endorsements responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants