Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

Legend in the map and the data in the map seems different #57

Closed
steffyjohn opened this issue Mar 24, 2020 · 6 comments
Closed

Legend in the map and the data in the map seems different #57

steffyjohn opened this issue Mar 24, 2020 · 6 comments
Assignees
Labels
Status: In Progress Status : Question Further information is requested

Comments

@steffyjohn
Copy link

COVID-19 Tracker   India -legend

The legend used in the map for showing the color for corresponding data(Kerala) seems different as seen in the screenshot

@jeremyphilemon
Copy link
Collaborator

@shuklaayush hey can you look at this?

@sudevschiz
Copy link
Collaborator

@steffyjohn Seems fine for me. Can you elaborate?

@JunaidBabu JunaidBabu added the Status : Question Further information is requested label Mar 24, 2020
@JunaidBabu JunaidBabu added this to Needs triage in Website main Mar 24, 2020
@shuklaayush
Copy link
Member

I think the issue is that the state colours are assigned directly from a continuous colour space, while the legend is a sampled version of the colour space. Hence, there's the possibility of a mismatch. We can either switch to a continuous legend, or assign colours from the sampled colour space. Any thoughts?

@jeremyphilemon
Copy link
Collaborator

jeremyphilemon commented Mar 25, 2020

@shuklaayush You're right, the colors on the map are based on a scaling factor, I think it'd be appropriate if the legend used the same too!

Let me know if you'd like me to assign you for this fix!

@shuklaayush
Copy link
Member

@jeremyphilemon The legend is already scaled as well. I think the issue is rather that the legend is a fixed set of 6 coloured blocks instead of a continuous scale. Right now, the fixed colour is the colour of the lower bound of the range.

What do you think about this?

Screenshot from 2020-03-25 14-26-34

@jeremyphilemon
Copy link
Collaborator

Patched #51

Website main automation moved this from Needs triage to Closed Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: In Progress Status : Question Further information is requested
Projects
No open projects
Website main
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants