Skip to content
This repository has been archived by the owner on May 30, 2021. It is now read-only.

State DC and county District of Columbia are redundant #312

Closed
chunder opened this issue Mar 24, 2020 · 5 comments
Closed

State DC and county District of Columbia are redundant #312

chunder opened this issue Mar 24, 2020 · 5 comments
Assignees
@lazd

Comments

@chunder
Copy link
Collaborator

chunder commented Mar 24, 2020

Ok, so we have a state called DC and a county called District of Columbia in our published json/csv. We are actively scraping the state DC. It looks like the county District of Columbia was being sourced through JHU previously, and stopped getting updates on 3/11. Do we want/need to merge these somehow? Or just ignore for now?
@lazd
Copy link
Collaborator

lazd commented Mar 24, 2020

I think I found the issue; we're treating District of Columbia as a county if it comes from JHU, and as a state elsewhere.

@lazd lazd self-assigned this Mar 24, 2020
@lazd lazd closed this as completed in c93ba64 Mar 24, 2020
@lazd
Copy link
Collaborator

lazd commented Mar 24, 2020

@chunder fix pushed, I verified it's working by checking timeseries data. Let me know if you see any issues!

@lazd
Copy link
Collaborator

lazd commented Mar 24, 2020

image
Looking right on the map now

@chunder
Copy link
Collaborator Author

chunder commented Mar 24, 2020

Cool. I think it was already looking good on the map. Our state scraper was working fine. But our CSV/json/etc was outputting 2 records: one for state DC and one for District of Columbia.

@lazd
Copy link
Collaborator

lazd commented Mar 24, 2020

Yes, that should be fixed!

@roboter202 roboter202 mentioned this issue Aug 9, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lazd lazd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chunder @lazd