Skip to content
This repository has been archived by the owner on May 30, 2021. It is now read-only.

How should KOR quarantine location be handled #572

Closed
jacobmcgowan opened this issue Apr 1, 2020 · 4 comments
Closed

How should KOR quarantine location be handled #572

jacobmcgowan opened this issue Apr 1, 2020 · 4 comments
Assignees

Comments

@jacobmcgowan
Copy link
Contributor

In reference to PR #571, KOR lists quarantine as a separate location from the provinces and special cities so there is no location or population data to populate for that record. Should the population be set to the number of cases in quarantine or left undefined/0?

@jzohrab
Copy link
Contributor

jzohrab commented Apr 7, 2020

Hi @jacobmcgowan , thanks for the PR, which has been merged. Do you think this issue is still a valid question, or should we close it? Cheers and regards, jz

@jzohrab jzohrab self-assigned this Apr 7, 2020
@jacobmcgowan
Copy link
Contributor Author

Hello @jzohrab, I think it is still a valid question. In the PR I kept the population of quarantine to 0/not set. If that is how it should be handled then this question can be closed and there will be no change.

@jzohrab
Copy link
Contributor

jzohrab commented Apr 7, 2020

Thanks @jacobmcgowan: yes, if we don't have the data, then we should record it as null (not 0). If your code sets it to null, we're good.

@jacobmcgowan
Copy link
Contributor Author

Thank you. I'll close this issue then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants